Ensure to check the exit code of the mktun command *before* running
sleep, otherwise '$?' will resolve to the exit code of sleep itself,
thus nullifying the check.
Reported-by: Steffan Karger <stef...@karger.me>
Signed-off-by: Antonio Quartulli <a...@unstable.cc>
---
tests/t_net.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/t_net.sh b/tests/t_net.sh
index 97e947ab..49790f0f 100755
--- a/tests/t_net.sh
+++ b/tests/t_net.sh
@@ -35,17 +35,17 @@ reload_dummy()
$RUN_SUDO $openvpn --dev $IFACE --dev-type tun --rmtun >/dev/null
$RUN_SUDO $openvpn --dev $IFACE --dev-type tun --mktun >/dev/null
+ if [ $? -ne 0 ]; then
+ echo "can't create interface $IFACE"
+ exit 1
+ fi
+
# it seems that tun devices will settle on NO-CARRIER while not connected
to
# any process, but this won't happen immediately. To avoid having the
# NO-CARRIER bit appear in the middle of the tests - which would compromise
# the results - let's wait 1 sec here for it to settle.
sleep 1
- if [ $? -ne 0 ]; then
- echo "can't create interface $IFACE"
- exit 1
- fi
-
#ip link set dev $IFACE address 00:11:22:33:44:55
}
--
2.23.0
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
