Hi, On Fri, Aug 16, 2019 at 07:13:14PM +0200, David Sommerseth wrote: > On 08/08/2019 16:51, Arne Schwabe wrote: > > The previous auth-token implementation had a serious problem, especially > > when > > paired with an unpatched OpenVPN client that keeps trying the auth-token > > (commit e61b401a). [..] > Since I've tested and reviewed the rest in earlier rounds and the change from > previous version i sjust changing %lld to PRIu64, I'm giving > this my ... > > Acked-By: David Sommerseth <dav...@openvpn.net>
While I'm all happy to see this ACK (and I trust David to have done a full
review on the code changes), there is a slight problem with this - it
breaks "--disable-server" builds:
cc -DHAVE_CONFIG_H -I. -I../../../openvpn/src/openvpn -I../.. -I../../include
-I../../../openvpn/include -I../../../openvpn/src/compat
-I/usr/local/include -I/usr/local/include
-DPLUGIN_LIBDIR=\"/usr/local/lib/openvpn/plugins\" -Wall -Wno-unused-parameter
-Wno-unused-function -g -O2 -std=c99 -MT auth_token.o -MD -MP -MF
.deps/auth_token.Tpo -c -o auth_token.o
../../../openvpn/src/openvpn/auth_token.c
../../../openvpn/src/openvpn/auth_token.c:100:16: error: no member named
'auth_token' in
'struct tls_multi'
if (multi->auth_token)
~~~~~ ^
../../../openvpn/src/openvpn/auth_token.c:112:42: error: no member named
'auth_token' in
'struct tls_multi'
char *old_tsamp_initial = multi->auth_token + strlen(SESSION_ID_PREFIX);
~~~~~ ^
../../../openvpn/src/openvpn/auth_token.c:119:21: error: no member named
'auth_token' in
'struct tls_multi'
free(multi->auth_token);
~~~~~ ^
... so, can I have a v7 of this, plus an ACK...?
Sorry for being a spoilsport here.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
