Hi, On Fri, Feb 15, 2019 at 09:26:50PM +0100, David Sommerseth wrote: > So I can give this a full ACK for git master only.
I can see your line of reasoning, but there is another aspect to it - we
want to change the windows GUI to override script-security, to disarm
possibly dangerous .ovpn files that have "--up $eviltrickery" in them.
With this change, the GUI has a chance to tell people "look, this is
the problem. If you trust the source, you can enable scripts in this
config (press <here>), if not, you better leave the ovpn alone!" -
without, things will silently stop working for windows users...
But we *do* want this on windows, disable script-security unless
explicitely activated *outside* the .ovpn file...
(I'm halfway tempted to make this an #ifdef _WIN32, but that cannot
truly be the way forward)
So - I had planned to give this an ACK both for 2.4 and master, but
since you have reservations, we need to find the best way forward.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
