Hi, > +finish_QueryServiceStatusEx:; > + > + // Service is not started. Is it set to auto-start? > + // MSDN describes the maximum buffer size for QueryServiceConfig() > to be 8kB. > + // This is small enough to fit on stack. > > .. there shouldn't be a ";" after a label, and no C++ comments... but I > assume the uncrustify patch coming next will fix that...
The sentence following the finish_QueryServiceStatusEx label is a local
variable declaration. While MSVC and MinGW are fine with or without
semicolon, the Visual Studio 2017 IDE's IntelliSense is complaining with
"E1072: a declaration cannot have a label".
Now, I could leave that semicolon in place to keep IntelliSense false
warning away, but looking at the code I asked myself a question: "If my code
is so convoluted it produces a false warning to a bot, how convoluted it
must be for a human to understand?" False warnings are usually sign of
overcomplex or atypical code design. I have refactored the code.
>
> Something else might not be obvious to the reader:
>
> + if (pQsc->dwStartType <= SERVICE_AUTO_START)
> + {
>
> so what does "lesser than AUTO_START" mean? manual start? no start at
> all? Comparing for "lesser or equal" with something enum-like might
> warrant a comment /* BOOT_START = 0, SYSTEM_START = 1, AUTO_START = 2 */
> or so... (yes, I can google this, but still).
This is a very generic test "Is driver or service set to start automatically
in any phase of the system launch?" on the Windows. I've added a comment
with a brief explanation.
A patch will follow.
Regards,
Simon
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
