Hi, On Mon, Oct 29, 2018 at 06:20:40PM +0100, Arne Schwabe wrote: > This can be used to redirect all IPv6 traffic to the tun interface, > effectively black holing the IPv6 traffic. Without ICMPv6 error > messages this will result in timeouts when the server does not send > error codes. block-ipv6 allows client side only blocking on all > platforms that OpenVPN supports IPv6. On Android it is only way to do > sensible IPv6 blocking on Android < 5.0 and broken devices (Samsung).
Generally I agree with the need for this, so feature-ACK.
Functionally, I've tested this on Linux, and it does what it says
on the lid (I've only tested client, but if that works, I expect server
to work as well).
Style-wise, there is, unfortunately, still way to go - missing brackets,
non-pretty alignment, etc. -> so please run uncrustify, then send us
a v6.
Besides the uncrustify things, please leave af_addr_size() in socket.h -
its only callers are in socket.c, so the move to proto.h does not make
any sense anymore (I assume you wanted to call it from ip_checksum(),
but since that one does a local decision for 4/16 byte address size,
moving the other function is no longer needed).
Lastly, the context of the hunk in options.c has no
#ifdef ENABLE_PUSH_PEER_INFO
anymore, but "master" still has that - so please send the patch that
removes this #ifdef to the list as well :-)
So, "changes requested" :-) - thanks.
As a side note, how did you test the "without ifconfig-ipv6" variant?
When I tried this it refused to install the IPv6 routes...
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
