Hi, I build-tested with all of these patches using the openvpn-build VM in Vagrant[1]. After the build libopenvpnmsica.dll and tapctl.exe show up under tmp/installer/<arch>. So the build part is definitely working correctly.
How would I test that both of the above are operating as intended? Also, could a (Windows-oriented) person do a code review? -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock [1] https://github.com/OpenVPN/openvpn-vagrant Il 16/10/18 13:26, Simon Rozman ha scritto: > On MinGW builds, the Libtool produces libopenvpnmsica.dll. The MSVC > properties were updated to match this. > --- > src/openvpnmsica/openvpnmsica.props | 4 +++- > src/openvpnmsica/openvpnmsica_resources.rc | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/openvpnmsica/openvpnmsica.props > b/src/openvpnmsica/openvpnmsica.props > index 0e31bc4f..fa408296 100644 > --- a/src/openvpnmsica/openvpnmsica.props > +++ b/src/openvpnmsica/openvpnmsica.props > @@ -2,7 +2,9 @@ > <Project ToolsVersion="4.0" > xmlns="http://schemas.microsoft.com/developer/msbuild/2003";> > <ImportGroup Label="PropertySheets" /> > <PropertyGroup Label="UserMacros" /> > - <PropertyGroup /> > + <PropertyGroup> > + <TargetName>lib$(ProjectName)</TargetName> > + </PropertyGroup> > <ItemDefinitionGroup> > <ClCompile> > > <AdditionalIncludeDirectories>..\compat;$(TAP_WINDOWS_HOME)/include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> > diff --git a/src/openvpnmsica/openvpnmsica_resources.rc > b/src/openvpnmsica/openvpnmsica_resources.rc > index ce60b4a1..9e8069f4 100644 > --- a/src/openvpnmsica/openvpnmsica_resources.rc > +++ b/src/openvpnmsica/openvpnmsica_resources.rc > @@ -50,7 +50,7 @@ BEGIN > VALUE "FileVersion", PACKAGE_VERSION ".0" > VALUE "InternalName", "OpenVPN" > VALUE "LegalCopyright", "Copyright © The OpenVPN Project" > - VALUE "OriginalFilename", "openvpnmsica.dll" > + VALUE "OriginalFilename", "libopenvpnmsica.dll" > VALUE "ProductName", "OpenVPN" > VALUE "ProductVersion", PACKAGE_VERSION ".0" > END > _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
