On 08/10/18 12:46, Lev Stipakov wrote: > From: Lev Stipakov <l...@openvpn.net> > > This patch fixes "unused variable/unreferenced format parameter" > warnings in different places, kudos to Visual Studio compiler > for discoveing some of those. > > Signed-off-by: Lev Stipakov <l...@openvpn.net> > --- > src/openvpn/forward.c | 2 +- > src/openvpn/init.c | 2 +- > src/openvpn/init.h | 2 +- > src/openvpn/mtcp.c | 2 +- > src/openvpn/mudp.c | 2 +- > src/openvpn/multi.c | 28 +++++++++++++--------------- > src/openvpn/multi.h | 8 ++++---- > src/openvpn/openvpn.c | 2 +- > src/openvpn/tun.c | 11 ++++------- > src/openvpn/tun.h | 2 +- > src/openvpn/win32.c | 3 +-- > 11 files changed, 29 insertions(+), 35 deletions(-)
I was about to pull this in, based on Simons ACK ... but below is something I
think we could do better.
> diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
> index 8440f31..ae4d1d2 100644
> --- a/src/openvpn/multi.c
> +++ b/src/openvpn/multi.c
> @@ -2936,7 +2934,7 @@ multi_process_drop_outgoing_tun(struct multi_context
> *m, const unsigned int mpp_
> */
>
> void
> -route_quota_exceeded(const struct multi_context *m, const struct
> multi_instance *mi)
> +route_quota_exceeded(const struct multi_instance *mi)
> {
> struct gc_arena gc = gc_new();
> msg(D_ROUTE_QUOTA, "MULTI ROUTE: route quota (%d) exceeded for %s (see
> --max-routes-per-client option)",
> @@ -3373,7 +3371,7 @@ init_management_callback_multi(struct multi_context *m)
> }
>
> void
> -uninit_management_callback_multi(struct multi_context *m)
> +uninit_management_callback_multi(void)
> {
> uninit_management_callback();
> }
Is there any reasonable reason we keep this simple wrapper function? The
users of it is very limited and I struggle to see the value of it. Can't we
just wipe this out out? This has been unchanged since the initial BETA21 SVN
branch dating back to 2005. I struggle to see us changing anything drastic in
this context.
--
kind regards,
David Sommerseth
OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
