On 19/10/18 17:56, David Sommerseth wrote: > From: Heiko Hund <heiko.h...@sophos.com> > > The previous implementation had the problem that it was not fully > compatible with printf() and could only detect % format directives > following a space character (0x20). > > It modifies the format string and inserts marks to separate groups > before passing it to the regular printf in libc. The marks are > later used to separate the output string into individual command > line arguments. > > The choice of 0x1D as the argument delimiter is based on the > assumption that no "regular" string passed to argv_printf_*() will > ever have to contain that byte (and the fact that it actually is > the ASCII "group separator" control character, which fits its > purpose). > > This commit has been updated by David Sommerseth based on his feedback > on the mailing list discussions earlier on. > > Signed-off-by: Heiko Hund <heiko.h...@sophos.com> > Signed-off-by: David Sommerseth <dav...@openvpn.net> > --- > src/openvpn/argv.c | 266 ++++++++++++--------------- > src/openvpn/argv.h | 4 +- > src/openvpn/route.c | 8 +- > src/openvpn/tun.c | 24 +-- > tests/unit_tests/openvpn/test_argv.c | 58 +++++- > 5 files changed, 192 insertions(+), 168 deletions(-)
This is a rebase of [0,1] on top of git master 2b15c11716e0d. I've added my review suggestions directly to this commit, as can be found here [2]. The doxygen suggestion is coming as the last patch in this patch-set. [0] <https://patchwork.openvpn.net/patch/71/> [1] <https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15834.html> [2] <https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15868.html> -- kind regards, David Sommerseth OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
