Am 10.10.18 um 08:44 schrieb Steffan Karger:
> Commit 674b166 ("Fix build warnings related to get_random()") broke the
> unit tests for mbedtls, because <mbedtls/cipher.h> was now included via
> platform.c -> crypto.h -> crypto_backend.h, but the crypto cflags were
> not included for that unit tests.
> 
> Since we got rid of --disable-crypto, we can now fix this by simply always
> including the CRYPTO_CFLAGS in the TEST_CFLAGS (and the CRYPTO_LIBS in the
> TEST_LDFLAGS). This should not only fix this occurrence, but also prevent
> similar problems in the future.
> 
> Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com>
> 
> # Conflicts:
> #     tests/unit_tests/openvpn/Makefile.am

This should not be in the commit message.


Otherwise this looks good. It also passes the travis build for me.

Acked-By: Arne Schwabe <a...@rfc2549.org>


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to