Your patch has been applied to the master branch.
Cursory review, looks all reasonable, and passes my local t_client tests
plus a windows build ("just to be safe").
Spurious extra whitespace fixed on the go.
There is one thing that Selva commented on on the first round of this
patch in December 2015 which you might want to look at - while
ENABLE_CLIENT_CR depended on ENABLE_MANAGEMENT, there's a code path in
misc.c which is useful also on "non management enabled" clients, in
get_user_pass_cr() - "Get username/password from standard input?"
now depends on #ifdef ENABLE_MANAGEMENT, which is what we *had*, but
might not be what we *want*... as far as I can see, these two blocks
should not be dependent on management functions (didn't test, though).
commit 66b9409bb25402c1bfcd66359332792cf57d0825 (master)
Author: Arne Schwabe
Date: Wed Oct 10 16:25:27 2018 +0200
Remove MANAGMENT_EXTERNAL_KEY, MANAGMENT_IN_EXTRA, ENABLE_CLIENT_CR
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Steffan Karger <steffan.kar...@fox-it.com>
Message-Id: <20181010142527.27025-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/search?l=mid&q=20181010142527.27025-1-a...@rfc2549.org
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
