On Mon, Oct 8, 2018 at 6:42 AM Lev Stipakov <lstipa...@gmail.com> wrote:
> Hi, > > Makes sense. Tested on VS2017. > > Acked-by: Lev Stipakov <l...@openvpn.net> > > Since in MinGW/VS we only build openvpnserv with unicode I wonder if we > should get rid of #if(n)def UNICODE ? > In fact the non-unicode build is its unlikely to work anymore -- there are number of places we implicitly assume that TCHAR = WCHAR. So assuming UNICODE is defined (and refusing to build otherwise) would be good. Selva
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel