Hi, On Sun, Nov 12, 2017 at 04:48:30PM +0800, Antonio Quartulli wrote: > *-inline.h files are not very useful anymore. > In the attempt of cleaning up the code some more, > merge them into their main header files. > > At the same time, move functions from fowrard.h > to forward.c, when they are used only in the latter. > > No functional change is part of this patch. > > Cc: Steffan Karger <stef...@karger.me> > Signed-off-by: Antonio Quartulli <a...@unstable.cc>
I'd love to merge this, but I can't - besides the easily fixed rebases ("the company that is mentioned in the copyright notices has been renamed"), there are actual changes in pf-inline.h that make it different from "the pf-inline.h that the patch removes" @@ -31,20 +31,24 @@ #define PCT_SRC 1 #define PCT_DEST 2 static inline bool -pf_c2c_test(const struct context *src, const struct context *dest, const char *prefix) +pf_c2c_test(const struct pf_context *src_pf, const struct tls_multi *src, + const struct pf_context *dest_pf, const struct tls_multi *dest, + const char *prefix) ... -pf_addr_test(const struct context *src, const struct mroute_addr *dest, const char *prefix) +pf_addr_test(const struct pf_context *src_pf, const struct context *src, + const struct mroute_addr *dest, const char *prefix) so it seems you had "pf changes" in your tree when sending this patch... Can you easily rebase this to "unchanged master"? gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel