Another ACK from me, looks good. Your patch has been applied to the master and release/2.4 branch.
(This is refactoring so normally shouldn't go to 2.4, but since the "set interface to DHCP" patch really is really fixing an omission in the initial 2.4 interactive service implementation, I see this as a necessary prerequisite to a bugfix) Test compiled on ubuntu1604/mingw, did not actually run. commit 4eb465537ce06e07ee63c2fc93c7b192dd4e29de (master) commit f0516a803fdcf588be67159a240d6ec840ad0090 (release/2.4) Author: Selva Nair Date: Tue Oct 2 16:01:12 2018 -0400 Move get system directory to a separate function Signed-off-by: Selva Nair <selva.n...@gmail.com> Acked-by: Alon Bar-Lev <alon.bar...@gmail.com> Message-Id: <1538510474-27602-1-git-send-email-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17518.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel