On 03/10/18 17:08, Selva Nair wrote: > > > To make code more clear, change return type to bool. Also > use stdbool.h header instead of bool definition macros. > > We do use BOOL all over the service code (unavoidable with > Windows API), and bool is used in only one or two places. So would it > be better to just change this to BOOL/TRUE/FALSE and not include > stdbool.h?
Several years ago, we started towards a path to get rid of the BOOL/TRUE/FALSE stuff, in favour of stdbool.h. And when we moved towards -std=c99, this made this move even more reasonable. But ... are you saying Windows C compilers we use/support does not support stdbool.h? Even with -std=c99? I would prefer we switch over to using standard types instead of our own "workaround" solutions wherever possible. -- kind regards, David Sommerseth OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
