Hi, On Thu, Jul 12, 2018 at 01:56:14AM +0800, Antonio Quartulli wrote: > > Why not just add prototypes at the top? > > Because I wanted the result to be clean code :)
Prototypes are clean code :-)
> Imho, prototypes should be used only if really needed (i.e. when
> re-ordering is not an option).
>
> The information about what/why was introduced can still be extracted
> with a "git log -S$something_here".
Won't help if I want to see how a particular line came to be - and this
is something relevant if you try to understand why "openvpn used to do
things differently" in earlier versions.
> I wouldn't make such a big deal of "breaking git blame" if the changes
> slowly move towards cleaner code.
I'm not objecting if it moves "towards cleaner code" (like the 2.4
reformatting, or moving code blobs to smaller units) - but "just move
it around in the same source file" is not achieving much cleaning,
so I consider the negative aspects to be stronger in that case.
> Actually some functions did not strictly needed to be moved, but I
> wanted all the stream_buf helpers to be in the same place and not
> scattered along socket.c. This can be changed if you think it's too
> invasive.
I do.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
