Hi, On Thu, Apr 19, 2018 at 7:23 AM, Simon Rozman <si...@rozman.si> wrote: > The OpenVPN Interactive Service documentation from > https://community.openvpn.net/openvpn/wiki/OpenVPNInteractiveService was > upgraded with a description of the client-service communication flow, > service registry configuration, and non-default instance installation. > --- > Thank you Selva for your review. > > Changes from [PATCH v4]: > > 1. git mv doc/interactive-service-notes.txt doc/interactive-service-notes.rst > 2. The section headings were restyled > 3. Selva's remark on openvpn.exe process termination has been taken into > consideration. The entire `openvpn.exe Termination` was reworded into a new > section `openvpn.exe Monitoring and Termination`. > > Rationale behind 1. and 2. is unification with documents located in > tap-windows6 > repository. > > Best regards, > Simon > > doc/interactive-service-notes.rst | 330 > ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 330 insertions(+) > create mode 100644 doc/interactive-service-notes.rst
Version v5 looks good and ACK from me. I still suggest to include in the dist tarball. As it stands one has to clone the repo to see it. > Giving it a second thought, there is no point into packaging this file for > non-Windows distributions, since the Interactive Service is Windows-specific. We have a common source distribution for all platforms and it includes Windows only bits like the interactive service sources. IMO, this does belong there. Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
