Hi
On Tue, Jun 5, 2018 at 10:30 PM, Antonio Quartulli <a...@unstable.cc> wrote:
> Hi,
>
> On 06/06/18 03:38, Selva Nair wrote:
>> Here is the diff of what I did for the Windows build run:
>>
>> diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
>> index 2e33880..75336a9 100644
>> --- a/src/openvpn/tun.c
>> +++ b/src/openvpn/tun.c
>> @@ -5824,9 +5824,9 @@ open_tun(const char *dev, const char *dev_type,
>> const char *dev_node, struct tun
>>
>> if (tt->type == DEV_TYPE_TUN)
>> {
>> - if (!tt->did_ifconfig_setup)
>> + if (!tt->did_ifconfig_setup && !tt->did_ifconfig_ipv6_setup)
>> {
>> - msg(M_FATAL, "ERROR: --dev tun also requires --ifconfig");
>> + msg(M_WARN|M_INFO, "WARNING: neither ifconfig nor
>> ifconfig-ipv6 specified");
>
> Why converting this FAtTAL to M_WARN|M_INFO?
> Isn't just better to quit the client if we receive no IPv* settings?
That was just to show why Windows needs some special handling here,
not a patch :)
Well, the reason why this used to be FATAL is because Windows is
special: tun mode requires --ifconfig. Whereas on other platforms its
not FATAL to run without any ifconfig: say the user sets a static IP
on the tun and somehow gets it to work.
At the same time, v4 address will work only if also present as an
ifconfig line (even if a manual method of assigning the IP is in use).
So some FATAL check is still required to catch that. But making this
combination check FATAL is not the same thing. I'm not entirely sure
of the best approach, but, anyway, its your patch :)
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
