Hi,
On Mon, Apr 23, 2018 at 11:28:13AM +0200, Christian Hesse wrote:
> @@ -1151,6 +1151,14 @@ do_uid_gid_chroot(struct context *c, bool no_delay)
> /* set user and/or group if we want to setuid/setgid */
> if (c0->uid_gid_specified)
> {
> +#ifdef ENABLE_SYSTEMD
> + if (sd_notify(0, "READY=0") > 0 && getuid() != 0)
> + {
> + msg(M_INFO, "NOTE: Running from systemd with non-root uid,
> skipping downgrade");
> + return;
> + }
> +#endif
> +
> if (no_delay)
This is not a good approach.
If you run with a limited capability model, then just do not set "setuid"
in your config files, and document clearly that this is incompatible. But
do not litter general-purpose code with #ifdef SYSTEMD bits that will randomly
ignore user-specified options.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
