Hi,
On Wed, Apr 18, 2018 at 2:58 AM, Gert Doering <g...@greenie.muc.de> wrote:
> On Tue, Apr 17, 2018 at 09:45:24PM -0400, Selva Nair wrote:
> > (ii) The driver version shows up as 9.0.0.21 -- this is apparently taken
> > from the inf file. Why is it not 9.21.3? The file version is 9.21.3 9/21
> as
> > expected.
>
> I have no idea how the various values in version.m4 should work. There
> are many numbers...
>
> What I have (after bumping all "21" to "22", and ".2/.3" to ".1") is:
>
> define([PRODUCT_NAME], [TAP-Windows])
> define([PRODUCT_PUBLISHER], [OpenVPN Technologies, Inc.])
> define([PRODUCT_VERSION], [9.22.1])
> define([PRODUCT_VERSION_RESOURCE], [9,0,0,22])
> define([PRODUCT_TAP_WIN_COMPONENT_ID], [tap0901])
> define([PRODUCT_TAP_WIN_MAJOR], [9])
> define([PRODUCT_TAP_WIN_MINOR], [22])
> define([PRODUCT_TAP_WIN_REVISION], [1])
> define([PRODUCT_TAP_WIN_BUILD], [601])
>
> So, no idea what PRODUCT_VERSION_RESOURCE does and why it is not "9,22,1,0"
> (or the like).
>
These are custom defines, so it depends on how those variables are used in
the resource file and the inf file.
The relevant defines in resource.rc are
VER_PRODUCTVERSION = major,0,0,minor --> 9,0,0,22
VER_PRODUCTVERSION_STR = "PRODUCTVERSION" "major/minor" --> "9.22.1 9/22"
(no idea why that 9/22 is added or build is not included).
The driver inf (OemVista.inf.in) file defines the driver version as
major,0,0,minor which matches the product version above.
Currently PRODUCT_VERSION_RESOURCE as such and revision, build numbers are
unused.
I have no idea whether there are any implications of changing the version
in two places (resource and inf) consistently to major,minor,release,build.
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
