Hi,
One comment based on stare-at-code only:
On 12-03-18 02:17, selva.n...@gmail.com wrote:
> @@ -636,6 +640,8 @@ find_certificate_in_store(const char *cert_prop,
> HCERTSTORE cert_store)
> }
> if (!*++p) /* unexpected end of string */
> {
> + msg(M_WARN, "WARNING: cryptoapicert: error parsing <%s>.",
> cert_prop);
> + return NULL;
> break;
> }
The break after the return looks a bit strange, maybe remove it?
Also, this looks like a somewhat unrelated fix. I would have personally
preferred it in a separate patch (so we can e.g. backport it easily even
if we decide not not backport the functional change).
Otherwise the code and functional changes look good to me. I'll try to
find some time to compile this and test it on windows later.
-Steffan
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
