Hi, On Fri, Dec 08, 2017 at 01:07:47PM +0100, Steffan Karger wrote: > To avoid a dependency on misc.c - which is a dependency mess - in the > tls-crypt unit tests, split the env_set functionality out into it's own > file. > > Signed-off-by: Antonio Quartulli <anto...@openvpn.net> > Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com>
*sigh* Not exactly sure what to do with this one - I was about to ACK and merge this, but it fails cmocka building tls_crypt_testdriver-env_set.o: In function `env_allowed': /tmp/openvpn-236/tests/unit_tests/openvpn/../../../src/openvpn/env_set.c:417: undefined reference to `script_security' /tmp/openvpn-236/tests/unit_tests/openvpn/../../../src/openvpn/env_set.c:417: undefined reference to `script_security' ... because *that* change is in 9/10... So while the change itself is fine (besides the "%lld" to PRIi64 change in setenv_long_long() that came in with 06ad53e067d9a8b) it will cause lots of build fails for the foreseeable future, so I'm not sure it's a good plan. gert -- now what should I write here... Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
