Hi,

On Wed, Feb 21, 2018 at 2:36 AM, Gert Doering <g...@greenie.muc.de> wrote:
> Hi,
>
> On Wed, Feb 21, 2018 at 02:07:03AM -0500, Selva Nair wrote:
>> >> *This* one breaks LibreSSL compilation (namely, the OpenBSD buildbot),
>> >> because
> [..]
>> Tested using the freebsd-11 box in openvpn-vagrant and did pkg install
>> libressl-2.6.4 (that replaces openssl 1.1.0).
>>
>> This particular error gets fixed by adding
>> !defined(LIBRESSL_VERSION_NUMBER) in two places.
>>
>> I can send a patch for this.
>
> This would be appreciated (please --cc me directly as the list is still
> not working properly).
>
>> But there are other errors:
>>
>> In file included from crypto_openssl.c:44:
>> ./openssl_compat.h:699:1: error: static declaration of
>> 'SSL_CTX_set_min_proto_version' follows
> [..]
>> ./openssl_compat.h:728:1: error: static declaration of
>> 'SSL_CTX_set_max_proto_version' follows
>>       non-static declaration
> [..]
>> In openssl those are macros but not in libressl so the current
>> openssl_compat.h defs don't work.
>
> This is interesting.  Seems my OpenBSD version is too old, as I've not
> seen these errors in my buildbots.

This could be also because of using the vagrant box with freebsd-11.
It came up with openssl 1.0 (not libressl) installed -- is that the
default? And there were no build errors as external-ec-key gets
disabled with openssl 1.0. On installing openssl 1.1.0g and
rebuilding, again, no errors as expected.

The only libressl package that showed up with  "pkg search" was 2.6.4
and installing that removed openssl 1.1.0g (which it shouldn't but
that's a different topic). Then the missing EC_KEY_METHOD and
conflicting signatures for SSL_CTX_set_max_proto_version etc showed
up.

Anyway, I am sending a patch for disabling external-ec-key code when
libressl is in use.

Selva

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to