Hi, On Thu, Jan 25, 2018 at 12:00 PM, Steffan Karger <steffan.kar...@fox-it.com> wrote: > On 25-01-18 16:14, Selva Nair wrote: >> A more useful thing to do is to catch the case of user setting min = >> 1.2 (as in trac 977) and we changing max to 1.1 when key is in a >> legacy key store. That would cause a handshake failure with a cryptic >> error. Better to catch early with a helpful warning. Will consider a >> patch for that and trim down the above log message at that time. > > Ah, I actually have a patch ready for that in my local master branch, > but still needed to send it out. So if you haven't started yet, I can > send that out to the list. Otherwise I'll happily discard mine :)
No, I'll defer to you, I haven't written one. Was just looking into it and realized it may require a better get_min_proto_version compatibility function (current one returns 0). Thanks, Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
