Hi,
On Wed, Dec 6, 2017 at 12:18 PM, Simon Rozman <si...@rozman.si> wrote:
> Hi,
>
> I have briefly reviewed this patch. If you look at each
> get_interface_metric() call you'll notice exactly the same repeating
> pattern:
>
> tap_metric_v4 = get_interface_metric(index, AF_INET, &is_auto);
> if (is_auto)
> {
> tap_metric_v4 = 0;
> }
> tap_metric_v6 = get_interface_metric(index, AF_INET6, &is_auto);
> if (is_auto)
> {
> tap_metric_v6 = 0;
> }
>
> Should the get_interface_metric() be rewritten to return:
> 0 = automatic metric
> n = manual metric
>
>
That's exactly what the original version does and the purpose of the patch
is to not do so. Else this function is not useful when someone really wants
to
find what the metric is as the value of 0 hides that info. Note that even
when
automatic metric is in use the interface has some metric set.
I want to use it in another patch where the actual metric is required even
if automatic metric is in use.
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
