Hi, On 05/12/17 00:17, Selva Nair wrote:
[cut] > I didn't mean to banish ASSERT: it does have some legitimate > uses. IMO, if the invalid input is due to programmer error, say, null > hostname, ASSERT is good and useful to catch it during tests. > But if its a user input error, say, empty hostname, or some runtime > error, use of ASSERT calls for a very strong justification. > > Just expressing an opinion, I respect your choice here and below. In the past weeks I have witnessed how a nice ASSERT today can become the DoS of tomorrow. For this reason I am very reluctant to use ASSERTs on code that will run on the server and I rather prefer to print something BIG (that also the developer can see immediately). :) > >> [cut] > > Looks good and works as advertised. Thanks. > > Reviewed-by: Selva Nair <selva.n...@gmail.com> > Tested-by: Selva Nair <selva.n...@gmail.com> > Acked-by: Selva Nair <selva.n...@gmail.com> > Thanks! -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
