On Sun, Dec 3, 2017 at 1:54 PM, Gert Doering <g...@greenie.muc.de> wrote:
> Hi,,
>
> On Sat, Dec 02, 2017 at 11:38:28PM -0500, Selva Nair wrote:
> > Responding to this old version just to be on record.
> >
> > I realized patch this was assigned to Gert on patchwork too late after
> > started responding on my own. Sorry for jumping the gun. Have to make
> > keeping an eye on patchwork a habit..
> >
> > I'll leave the latest v4 alone.
If that is the consequence of assigning patches to people on patchwork,
> we should stop doing so (Antonio, are you listening? :-) ).
I didn't want to step on anyone's toes... But based on Antonio's
explanation,
I take that remark back. Will look into v4 as soon as I get some time to
test it.
> Obviously
> the patch was in dire need of a good review, and if you have time while
> I am busy with family things, this is more than welcome.
>
> Voluntarily *taking* a patch for review is useful as a flag "I'm going to
> handle this", but third-party-tagging "this is for Gert!" seems to have
> potential for backfiring, so maybe we shouldn't do that, then.
Agreed. I just didn't realize Antonio delegated it to you and assumed
all "delegation" are indications that the person has volunteered to look
into it. As for me, I totally welcome others reviewing something I delegated
to myself, or commenting/criticizing/extoling (or tipping :) my reviews
(multiple reviews are indeed great).
But I wouldn't particularly want others delegating work to me :)
So let's continue the practice of delegating to self, not to others.
We can always use the list (or IRC for those who frequent the channel)
for requesting reviews etc.
Best,
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
