Hi,
On Thu, Nov 30, 2017 at 10:26 PM, Selva Nair <selva.n...@gmail.com> wrote:
> Hi Jon,
>
> On Thu, Nov 30, 2017 at 8:41 PM, Jonathan K. Bullard <jkbull...@gmail.com>
> wrote:
>
>> Thanks, Selva,
>>
>> On Wed, Nov 29, 2017 at 9:03 PM, Selva Nair <selva.n...@gmail.com> wrote:
>> >
>> > I have made a draft implementation of this feature that was discussed
>> in a previous thread. A test executable (GUI only) is in this pre-release:
>> >
>> > https://github.com/selvanair/openvpn-gui/releases/tag/v11-echo-msg
>> <SNIP>
>> >
>> > Also see some technical notes included in the above link.
>>
>> The technical notes say
>>
>> In case of "echo msg text" the previous text, if any, is appended
>> with a new line. An empty text in this case will just add a new line.
>>
>>
> That was a poor way of saying that "echo msg text" will display a single
> line of text, not two lines as would be expected if an '\n' is
> automatically
> appended.
>
>
>> Is that the same as
>>
>> In case of "echo msg text" the previous text, if any, is appended
>> with text and then a new line. An empty text in this case will just
>> add a new line.
>>
>>
> Yes, that would be a less confusing way to word it provided an
> additional remark is added: that the last newline so added is ignored
> during
> display (see below).
>
>
>> ? (That is, the new line comes after the text, not after the previous
>> text.)
>>
>
> Well, here is what I thought should happen:
>
> echo msg Text
> echo msg-window title
>
> should display "Text" as a single line (ignoring any "soft" linebreaks
> added by the UI for display purposes). For this to happen no '\n' should
> get appended to "Text".
>
> echo msg Text1
> echo msg Text2
> echo msg-window title
>
> leads to "Text1\nText2" displayed in 2 lines
>
> Alternatively the one could say "msg Text" implicitly appends a newline
> character(s) to "Text" except that the last implicit newline does not
> cause an
> empty line to be displayed.
>
> Isn't that the expected behaviour?
>
That's fine with me.
Selva
>
> P.S: In reality I add about a line of blank space at the top and bottom
> before display
> for aesthetic reasons, but that is beside the point.
>
Let's leave that as implementation defined. It may be different in
notifications and windows, too.
Best regards,
Jon
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
