ACK.  Patch looks good and passes t_server tests (2.2, 2.3, 2.4 clients).

(Also registering Antonios ACK, as the v2 code was technically working,
and this is just getting it fully right)

Since the patch is fairly trivial I've let myself be convinced that it's
a long-term support thing to have this in 2.4 (namely: get rid of P_DATA_V1
as soon as everyone has migrated to 2.4, not having to wait until after
2.5).

Your patch has been applied to the master and release/2.4 branch.

commit 3b9cce657b0ba876c56ee6f14664a8a77f5b82d5 (master)
commit 6232c7b3827f90d9b25135c523703204bc2095c0 (release/2.4)
Author: Steffan Karger
Date:   Fri Nov 24 14:58:23 2017 +0100

     Use P_DATA_V2 for server->client packets too

     Signed-off-by: Steffan Karger <stef...@karger.me>
     Acked-by: Antonio Quartulli <anto...@openvpn.net>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <1511531903-19349-1-git-send-email-steffan.kar...@fox-it.com>
     URL: 
https://www.mail-archive.com/search?l=mid&q=1511531903-19349-1-git-send-email-steffan.kar...@fox-it.com
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to