Hi, On Wed, Nov 22, 2017 at 01:53:50PM -0500, Jim Carroll wrote: > Question -- We'd like to submit a patch. Is the correct procedure still to > submit patches via email as described > https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation#Dailydevel > opment. Or is appropriate for us to just fork on github and push patches > there?
Most preferred way is - you do a git clone of the tree - checkout master - apply changes there - "git commit -s" - git send-email --to=openvpn-devel@lists.sourceforge.net this will make reviewing and applying (and keeping track of patches in patchwork) much easier than any other method. For simple patches, "just send a diff by mail" is ok, but so many MUA/MTAs tend to wreck whitespace that "git send-email" is just more safe in that regard. > Conceptually, I believe supporting FIPS in OpenVPN will require four broad > changes: > > 1) A change to configure.ac to help build process find > OpenSSL FIPS Object Module > 2) A new option to OpenVPN, eg: --fips-mode > 3) Code change to enable FIPS & Allow MD5 for PRF > 4) Build process documentation to build, eg: where to > get OpenSSL pieces and how to build > > Do we need to run this by anyone, or do we just start patching? You start patching, commit & send-email your diffs, and then face the reviews :-) - I'm not the one who has any idea about FIPS and our crypto stuff in general, so Antonio, David or Steffan are likely going to review & ACK/NAK the result... I only look at style and remember things :-) gert -- now what should I write here... Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
