On 11/11/2017 04:55 PM, Gert van Dijk wrote:
> Hi François,
Hi Gert,
> This is not a full review, but as just discussed face-to-face, here are
> some points from me:
Thanks for taking the time to look at it!
> 1) Could we also please please enable this for non-management interface
> use case? I guess it's just adding the status version number 4 in
> option/config validator (and the manpage).
Yes, I will add this as well.
> 2) With 1), perhaps it would be more clear to use *version* in your
> message/description so that it's about the --status-version option, not
> the --status option.
This got confused because in the management interface (via telnet) you'd
use "status" and not "status-version".
> 3) I believe the output structure is not valid JSON with the "END"
> string at the end.
All (multiline) responses end with "END", so that's why I did that as
well. Ideally I'd construct a JSON object that does not include newlines
at all and just responds as:
SUCCESS: { ... }
> (FYI I'm about to upload a patch to include more documentation on the
> --status-version option and to include a new field as well.)
Great!
Cheers,
François
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
