Hi,
On Thu, Sep 21, 2017 at 12:58 PM, Antonio Quartulli <a...@unstable.cc> wrote:
>
>
> On 20/09/17 23:34, Selva wrote:
> > Hi,
> >
> > On Fri, Sep 15, 2017 at 2:46 PM, <selva.n...@gmail.com> wrote:
> >
> >> From: Selva Nair <selva.n...@gmail.com>
> >>
> >> In particular, this eliminates the message that says
> "explicit-exit-notify
> >> is ignored by previous <connection> blocks" when the option is pushed.
> >>
> >> Note: pull_mode is identified as "allowed & OPT_P_PULL_MODE" matching
> with
> >> the
> >> definition in add_options().
> >>
> >> Reported by: Eike Lohmann e.lohm...@ic3s.de
> >> https://www.mail-archive.com/openvpn-users@lists.
> >> sourceforge.net/msg04052.html
> >>
> >> v2: move the check to verify_permissions() as suggested by
> >> Gert <g...@greenie.muc.de>
> >>
> >> Signed-off-by: Selva Nair <selva.n...@gmail.com>
> >> ---
> >> src/openvpn/options.c | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >
> >
> > Does this look good now?
>
> pull_mode is already computed in add_options() and could just be passed
> to verify_permission(). However, adding another parameter to the
> function call is probably not worth the gain.
>
> Personally, I think this patch looks good now.
>
>
> Cheers,
>
Thanks :)
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
