On 07/09/17 08:13, Gert Doering wrote:> HI, > > On Thu, Sep 07, 2017 at 04:28:27AM +0200, David Sommerseth wrote: >> We are using a deprecated function, LZ4_compress_limitedOutput(), which >> will be removed with time. The correct function to use is >> LZ4_compress_default(). >> Both function takes the same number of arguments and data types, so the >> change >> is minimal. > > I wonder why we should bother to have a wrapper function here. > > We can ship a lz4 library that has the new function, and if a system only > provides an older version, declare it unsuitable (configure check) and > use the bundled one.
Yeah, I was thinking along those lines too when working on this patch. I just remembered vaguely our IRC chat long time a go and looked back at the initial mail discussion, and there was a preference for the wrapping back then. But I like much more that we have a defined LZ4 version which we support, and ditch the #ifdef'ed wrapper. I'll send a v2 soon. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
