20 июл. 2017 г. 19:50 пользователь "Selva Nair" <selva.n...@gmail.com>
написал:
Hi,
On Thu, Jul 20, 2017 at 4:36 AM, Илья Шипицин <chipits...@gmail.com> wrote:
> any news ?
>
> 2017-07-12 20:50 GMT+05:00 Илья Шипицин <chipits...@gmail.com>:
>
>>
>>
>> 2017-07-12 20:06 GMT+05:00 Selva Nair <selva.n...@gmail.com>:
>>
>>>
>>> On Wed, Jul 12, 2017 at 10:45 AM, Илья Шипицин <chipits...@gmail.com>
>>> wrote:
>>>
>>>> 2017-07-12 18:54 GMT+05:00 Selva Nair <selva.n...@gmail.com>:
>>>>
>>>>>
>>>>> On Wed, Jul 12, 2017 at 4:46 AM, Илья Шипицин <chipits...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> No interest ?
>>>>>>
>>>>>> 9 июл. 2017 г. 19:46 пользователь "Ilya Shipitsin" <
>>>>>> chipits...@gmail.com> написал:
>>>>>>
>>>>>>> Currently, we do not check for mingw-gcc version. For example,
>>>>>>> Debian 7 is shipped with 4.6.3, which does not know about ENETUNREACH
>>>>>>> ---
>>>>>>>
>>>>>>> this is for 2.4 and HEAD branches
>>>>>>>
>>>>>>> configure.ac | 14 ++++++++++++++
>>>>>>> 1 file changed, 14 insertions(+)
>>>>>>>
>>>>>>> diff --git a/configure.ac b/configure.ac
>>>>>>> index 60bb465..80b26ff 100644
>>>>>>> --- a/configure.ac
>>>>>>> +++ b/configure.ac
>>>>>>> @@ -708,6 +708,20 @@ m4_define(
>>>>>>> [setsockopt getsockopt getsockname poll]dnl
>>>>>>> )
>>>>>>> if test "${WIN32}" = "yes"; then
>>>>>>> +
>>>>>>> +#
>>>>>>> +# check for ENETUNREACH
>>>>>>> +# at least Debian 7 is shipped with gcc-mingw-w64-4.6.3, which is
>>>>>>> too old
>>>>>>
>>>>>>
>>>>> Instead of checking for a particular define why not require a minimal
>>>>> version of gcc ? I do not know what version that would be, though..
>>>>>
>>>>
>>>>
>>>> if you would try to build using ubuntu-14.04, build would fail (I'll
>>>> submit configure patch for that soon as well).
>>>> however, if modified compiler would used https://community.openvpn.net/
>>>> openvpn/wiki/PatchingDebs ... the build will succeed
>>>>
>>>
>>> There is no reliable way to support arbitrarily patched build
>>> environments. If I patch mingw in ubuntu 14-04 to have ENETUNREACH
>>> defined, the above check would pass but build may still fail somewhere else.
>>>
>>
>>
>> ENETUNREACH check is for Debian 7.
>>
>> Ubuntu 14.04 is shipped with broken fwpmu.h:
>> https://github.com/chipitsine/openvpn/commit/03013fd6f5b57a1
>> 22302ce1a534a7061acde9d5b :)
>>
>>
>>>
>>> I still think we should just determine what official version of mingw-
>>> gcc is required and add a test for it.
>>>
>>> Selva
>>>
>>
>
I still think we should just determine what official version of mingw-gcc
is required and add a test for it. :) If its just one define missing add it
to sources as we already do for some fwpm defines in block_dns.c
I generally agree with you. However, your approach needs some future
investigation.
1) I do not know the minimal required version
2) it might turn out that version itself means almost nothing. For example,
openssl shipped with alnost any linux distro is constantly updated, while
its version remains the same (just patch level is increased). Same with
mingw, ubuntu 14.04 is shipped with broken mingw, while Samuli supports
patched repo, which is ok
So, while I agree your approach sounds resonable, I still suggest to start
with my patch
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
