ACK. The patch looks generally reasonable ("if there is no such cipher, do not try to use it but print a clear message") though I have not been able to verify actual *failure* - tried on FreeBSD 9.3, which' openssl claims "no AES-256-CTR", but still, "PASS: tls_crypt_testdriver"
Since this is *test* infrastructure not "core code", this is still good enough to me. Your patch has been applied to the master and release/2.4 branch. commit 534c8f24bd8ceeaebb326f53363a4e40e970df1e (master) commit 84372cb6a67d1c088b01ed253697199995a8ab85 (release/2.4) Author: Steffan Karger Date: Mon May 15 16:44:43 2017 +0200 Skip tls-crypt unit tests if required crypto mode not supported Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1494859483-16466-1-git-send-email-steffan.kar...@fox-it.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14657.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel