Hi, Welcome to the mailing list.
On 26 May 2017 at 19:21, Farhan Ul Haq <far...@openvpn.net> wrote: > --- Well, that is a short commit message. Before we look into this patch, could you please supply a commit message that convinces why we would need this option? We already have a plethora of options, and don't want to add any more unless it is really necessary. The commit message isn't just to make us understand, but also to provide context for future developers who are searching the git logs for reasons why something in the code is the way it is. In general, I'd like to advise you to read this great blog post in detail before resubmitting: https://chris.beams.io/posts/git-commit/ Furthermore, just glancing at the code, I noticed: * this patch seems to be based on the release/2.3 branch, while patches should be based on the master branch. (And we only accept bugfixes in the release/2.3 branch, so this is very unlikely to be backported to release/2.3.) * this adds an options, but doesn't update the man page * this doesn't update Changes.rst Thanks, -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
