Hi,
On Mon, May 8, 2017 at 10:57 AM, David Sommerseth <
open...@sf.lists.topphemmelig.net> wrote:
> On 08/05/17 16:38, Selva Nair wrote:
> > Hi,
> >
>
On Mon, May 8, 2017 at 10:19 AM, David Sommerseth <dav...@openvpn.net>
>> wrote:
>> *
>> * STRUCT MEMBERS
>> *
>> - * *type_mask : The plug-in should set this value to the logical OR of
>> all script
>> + * type_mask : The plug-in should set this value to the logical OR of
>> all script
>> * types which the plug-in wants to intercept. For
>> example, if the
>> * script wants to intercept the client-connect and
>> client-disconnect
>> * script types:
>> *
>> - * *type_mask = OPENVPN_PLUGIN_MASK(OPENVPN_PL
>> UGIN_CLIENT_CONNECT)
>> + * type_mask = OPENVPN_PLUGIN_MASK(OPENVPN_PL
>> UGIN_CLIENT_CONNECT)
>> * | OPENVPN_PLUGIN_MASK(OPENVPN_PL
>> UGIN_CLIENT_DISCONNECT)
>> *
>> * *handle : Pointer to a global plug-in context, created by the
>> plug-in. This pointer
>
>
>
> >
> > Asking to set *handle to context_ptr is wrong too. One can't
> > dereference handle. So it will have to be interpreted as set handle
> > to pointer to pointer to the context but that is wrong.
> >
> > But as discussed in the other thread I think we should also change
> > the definition of handle in this struct.
> >
> > Reference to *handle in line 390 needs correction too (comment only
> > -- struct is fine).
>
> Yes, I saw that, but thought we should fix that when we know what is
> the right solution for the *handle vs handle. Just to keep things
> separate.
OK, that makes sense. Then this is good to go.
ACK.
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
