Thanks, please see v2 here
https://github.com/ValdikSS/openvpn-with-patches/commit/bb5893bdbd74b8168e1ad9561a55bd9449b1d5b5
On 26.04.2017 00:06, David Sommerseth wrote:
> On 25/04/17 22:40, ValdikSS wrote:
> I've quickly looked at it. I am by far no Windows developer, so I don't
> understand all the deeper contexts of the details. But I've left a few
> comments on github with some questions I think could help clarify your
> patch.
>
> Adding a few comment lines of "why" and documentation pointers on some
> of these details you set as "default" would help understand the code
> better. What your or we know as a fact today, doesn't mean we will
> remember that and correlate it with today's context in a few years.
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
