Hi,

On Mon, Apr 24, 2017 at 04:39:10PM +0200, David Sommerseth wrote:
> This patch have been tested on Scientic Linux 7.3 (RHEL clone) and
> FreeBSD 10.3-RELEASE-p11.
>
> v5 - Remove the right OPENSSL_LIBS and preserve the old one
>    - In PKG_CHECK_MODULES(), check for openssl instead of libssl
>      + libcrypto
>    - Fix tab/space issues once again
[..]

This looks good for me.

FreeBSD 10.3, no pkg-config               -> works
Gentoo, pkg-config                        -> works
FreeBSD 7.3, no pkg-config, openssl 0.9.8 -> fails (as it should)

   checking for OPENSSL... no
   checking additionally if OpenSSL is available and version >= 1.0.1... 
configure: error: OpenSSL version too old

NetBSD 7.0.1, pkg-config, openssl 1.0.1t  -> works
OpenBSD 6.0, pkg-config, LibreSSL 2.4.2 (OPENSSL_VERSION_NUMBER 0x20000000L)
                                          -> works


I'd like to see a review from Steffan whether we've anything left that
I didn't see in my setups (I run without setting env vars, with openssl
installed "in the default places"), but for my machines, this is good to 
go (=ACK).

[I'll have to go and upgrade a number of the older buildslaves, as some
of these do have 0.9.8<x> installed - so expect some errors when pushing,
but this is understood and inveitable]

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to