Hi,

On Tue, Apr 11, 2017 at 07:31:33PM +0200, David Sommerseth wrote:
> --- a/configure.ac
> +++ b/configure.ac
> @@ -859,9 +859,9 @@ if test "${enable_crypto}" = "yes" -a 
> "${with_crypto_library}" = "openssl"; then
>               # if the user did not explicitly specify flags, try to 
> autodetect
>               PKG_CHECK_MODULES(
>                       [OPENSSL],
> -                     [libcrypto >= 0.9.8, libssl >= 0.9.8],
> -             [have_openssl="yes"],
> -                     [have_openssl="no"] # Provide if-not-found to prevent 
> erroring out
> +                     [libcrypto >= 1.0.1, libssl >= 1.0.1],
> +                     [have_openssl="yes"],
> +                     [AC_MSG_ERROR([Minimum supported OpenSSL version is 
> 1.0.1])]

While this *looks* harmless, it has non-obvious side effects - from what
I observe, it breaks compilation on all platforms that do not have
pkg_config for OpenSSL, which was not a requirement earlier (and there
even was a comment to that extent, "to prevent erroring out").

In other words: all BSDs are broken now, no matter which openssl version
they have.

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to