Hi,
On Sat, Jan 28, 2017 at 3:06 AM, Ilya Shipitsin <chipits...@gmail.com>
wrote:
> MBEDTLS_VERSION, OPENSSL_VERSION were defined twice - in both
> .travis.yml and .travis/build-deps.sh files, the last one
> defined OPENSSL_VERSION via nonexistent OPENSSL_VERION
> variable, which lead us to use openssl-1.0.1 instead of
> openssl-1.0.2, I removed variable definition from build-deps.sh
>
> "cache: [ apt: true ]" is not a travis supported option, it was
> introduced by mistake, I removed it
>
> LD_LIBRARY_PATH was defined for the entire test run, it includes
> custom openssl build, which was picked by "wget", so "wget"
> could not verify SSL cert at https://www.openssl.org sometimes.
> We do not want wget to pick our custom LD_LIBRARY_PATH, so I moved
> that variable to "script" section
>
> LD_LIBRARY_PATH was defined for both linux and osx environments,
> for the second DYLD_LIBRARY_PATH must be defined instead
>
> v2: Upgrade openssl, mbedtls to the most recent versions
> ---
> .travis.yml | 8 ++++----
> .travis/build-deps.sh | 2 --
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
Moving down the LD_LIBRARY_PATH definition makes sense -- we need it (more
on that below) in the env to run the test executables, but do not want it
to modify the library search path for installed programs used for package
updates etc.
script:
> + - if [ "${TRAVIS_OS_NAME}" = "linux" ]; then export
> LD_LIBRARY_PATH="${PREFIX}/lib:${LD_LIBRARY_PATH}"; fi
> + - if [ "${TRAVIS_OS_NAME}" = "osx" ]; then export
> DYLD_LIBRARY_PATH="${PREFIX}/lib:${LD_LIBRARY_PATH}"; fi
On this platform DYLD_LIBRARY_PATH is what matters, so I think we should be
appending to it instead of redefining it in terms of LD_LIBRARY_PATH. That
is,
DYLD_LIBRARY_PATH="${PREFIX}/lib:${DYLD_LIBRARY_PATH}"
While this patch is good enough for travis builds, there is a more general
issue here. I think its the job of libtool to set -rpath properly (and/or
use a wrapper) so that uninstalled test programs pick up the library it was
linked with. Else a developer building using custom libs gets wrong
libraries loaded while running tests. A proper fix will eliminate the need
for tweaking LD_LIBRARY_PATH in the first place. But my libtool foo is
virtually nil to suggest a proper solution.
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
