On 19/01/17 16:32, Selva Nair wrote: > Hi, > > Thanks for the comments. > > On Thu, Jan 19, 2017 at 9:41 AM, David Sommerseth > <open...@sf.lists.topphemmelig.net > <mailto:open...@sf.lists.topphemmelig.net>> wrote: > > Any reason to have this AC_DEFINE? That puts HAVE_LD_WRAP_SUPPORT into > config.h, which I don't think makes much sense. If we don't have --wrap > support, would we have #ifdef HAVE_LD_WRAP_SUPPORT in the C code at all? > > > Repeating from related discussion on the PR page: AC_DEFINE is indeed > meant to add a preprocessor define (available to sources through > config.h). We do not have a use for it right now but we could --- say > one could provide an alternative to __wrap_xxx() in source, not sure how > though.
Exactly. There might be some possibilities, but I don't have a good idea currently. And I see even fewer possibilities where #ifdef around this would be a solution. I think a solution would require to compile and link a different set of source code providing a similar feature, which would anyway need to be primarily handled via configure.ac and Makefile.am. And considering this is limited to the LLVM linker and works fine with at least the GNU linker, I don't think we will spend too much time tackling this now. > So currently its just a preprocessor define that provides a solution > waiting for a problem. If the consensus is not to define it, fine with me. I have no issues adding such an AC_DEFINE when we have a good use-case for it. But if we don't need it now, I think it's best to keep things as simple as possible, in particular in the autotools stuff which can already be quite confusing. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
