ACK. This change enforces good manners, as we do on all other platforms - ensure the IP address is released/removed when we release the interface (some platforms do not have code for that because it's automatic, others have). Having an extra not-very-well-known option for this is a bit peculiar.
I have changed the commit message as requested, and also changed the tile line to add "... on Windows", to make clear this is platform specific. Your patch has been applied to the master and release/2.4 branch. commit db5b9b45508ea8f66ea80565279af3edd9300499 (master) commit 139cd1b14c57501bee36c1ec1dc5a037617ec29e (release/2.4) Author: Selva Nair Date: Tue Jan 3 15:38:03 2017 -0500 Always release dhcp address in close_tun() on Windows. Signed-off-by: Selva Nair <selva.n...@gmail.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1483475883-17450-1-git-send-email-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13814.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel