Hi, On Thu, Dec 29, 2016 at 07:57:26PM +0100, Christian Hesse wrote: > From: Christian Hesse <m...@eworm.de> > > We have voices that do not want to "litter ENABLE_SYSTEMD all over the > code". So move the systemd specific bits to platform_notify() in > platform.c.
While this is better, it's still far from a proper abstraction that could
be used for cross-platform notification - like Selva said, we might want
to add windows event logging eventually (quite likely a larger user base
than Linux)...
So, for a start, passing arguments to platform_notify() that do not make
sense to anything that is not sd_notify() is a non-starter.
Then, please investigate using the existing status file / management
interface code to add this, instead of adding new calls in init.c
(I mentioned this yesterday). If our existing status file / management
code is not up to more fine-grained notification, I'd rather see that
one improved, and then call out to systemd / windows events / ...
than new code in parallel to the existing notification code.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
