On Sun, Dec 25, 2016 at 06:09:01PM +0800, Antonio Quartulli wrote: > On Sun, Dec 25, 2016 at 10:44:45AM +0100, Steffan Karger wrote: > > > > On 19-12-16 02:39, Antonio Quartulli wrote: > > > Carrying around the INLINE_TAG is not really efficient, > > > because it requires a strcmp() to be performed every > > > time we want to understand if the data is stored inline > > > or not. > > > > > > Convert all the *_inline attributes to bool to make the > > > logic easier and checks more efficient. > > > > This makes sense, feature-ACK. > > > > > Signed-off-by: Antonio Quartulli <a...@unstable.cc> > > > --- > > [CUT] > > > > > Seeing the recurring "don't accidentially print key data" issues, I > > think adding a wrapper function to check for "[[INLINE]]" (and NULL?) > > would make sense.
Steffan, do we really need to check for NULL? I see that somewhere we use the np() function which already does it. But not everywhere. What is the general rule then? cron2 explained me on IRC that in the past some C programs would crash when trying to print NULL, but it should not be the case anymore (at least on Linux). I could keep the np() function where it is already used now. With a later patch I could then remove it completely or add it everywhere. What do you think? Cheers, -- Antonio Quartulli
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
