Hi, On Mon, Dec 19, 2016 at 04:31:26PM +0100, David Sommerseth wrote: > > I've no idea how to detect osx, but it is rather easy on travis-ci > > I'm strongly leaning towards a NAK on this approach, unless there exist > absolutely no other way. I don't want to see configure.ac carrying > Travis references for no good reason.
For a change, I agree with David :-)
Given that configure.ac does a good job in OS autodetection already
*-*-darwin*)
AC_DEFINE([TARGET_DARWIN], [1], [Are we running on Mac OS X?])
AC_DEFINE_UNQUOTED([TARGET_PREFIX], ["M"], [Target prefix])
have_tap_header="yes"
dnl some Mac OS X tendering (we use vararg macros...)
CPPFLAGS="$CPPFLAGS -no-cpp-precomp"
ac_cv_type_struct_in_pktinfo=no
;;
... it should not be too hard to add a check for "TARGET_DARWIN" to
the CMOCKA_INITIALIZED section.
Or add a "disable_cmocka=yes" to the *-*-darwin* section and test for
that later on (makes it easier to add other platforms that are not
using GNU ld).
*Or* just check for GNU ld, and disable cmocka testing if that's not
available - we already have a check in there that talks about
"checking for ld used by $CC", which seems to result in
"with_gnu_ld=yes"
if, well, GNU ld is used. So the cmocka init part could just add a
check
if [ yes != "$with_gnu_ld" ] ...
and set CMOCKA_INITIALIZED to "false". Done.
(I'm not very good in actual coding using the right macros, so I'm not
even suggesting a patch - but I'm happy to help concept-wise and run
tests)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
