Hi, On 14-12-16 21:07, David Sommerseth wrote: > Due to a bug in uncrustify 0.63
Should be 0.64. > diff --git a/dev-tools/reformat-all.sh b/dev-tools/reformat-all.sh > new file mode 100755 > index 0000000..11a6eca > --- /dev/null > +++ b/dev-tools/reformat-all.sh > @@ -0,0 +1,136 @@ > +#!/bin/bash If you replace the pushd/popd with a subshell, /bin.sh suffices (sligtly more portable). And, it's a good habit to start shell scripts with set -eu, to make sure you exit on failures, and don't use uninitialised variables. Finally, git complains about whitespace errors: Applying: dev-tools: Add reformat-all.sh for code style unification .git/rebase-apply/patch:173: trailing whitespace. .git/rebase-apply/patch:192: trailing whitespace. warning: 2 lines add whitespace errors. Other than these details (and what Selva mailed), the patch looks good. -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
