On 13/12/16 09:33, Gert Doering wrote: > Hi, > > On Tue, Dec 13, 2016 at 01:15:03AM +0100, David Sommerseth wrote: >> But I am wondering if it would be better to just do this in syshead.h >> instead: >> >> #if !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) >> #undef ENABLE_ASYNC_PUSH >> #endif > > We discussed this on IRC yesterday, and I like Lev's approach more. > > Your approach will "silently not do what the user requested" - the user > configured "--enable-async-push", and the resulting binary will not > have that functionality because we turned it off again. > > So erroring out in configure if incompatible build options are requested > sounds like a logical way to tell the caller "this is not what you want".
autotools and ./configure's task is primarily to *probe the system*, not to safe-guard the user against invalid feature combinations. It should ensure your system have what is needed to do a good build. Which is why I don't think such a check belongs in configure.ac. Because --enable-async-push should be ignored if the user have disabled support for plugins, becuase async push is a sub-feature of plugins. If async-push is enabled or disabled have nothing to do with if the system have all it needs to do an openvpn build or not. It is purely an openvpn internal switch. >> My point is that there's no real point of screaming about missing >> --enable-plugins if you have added --enable-auth-push. > > Someone added --enable-async-push to the configure command line, and they > expect this to have a different effect than "not putting it there". If someone added --disable-plugins, they don't need --enable-async-push. So no reason to scream about it. That it fails to build with that combo is actually more or less something which slipped through the ACK of the initial patch (mostly because very few disables plugins at all). Regardless, I won't NAK this pactch as it will resolve an issue. But it also won't get an ACK from me, because I do think this is an abuse of ./configure. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
