Hi,
Some nitpicking on the eleventh hour...
The comment does not agree with the code:
> +++ b/src/openvpn/push.c
> @@ -333,6 +333,16 @@ prepare_push_reply (struct context *c, struct
> gc_arena *gc,
> print_in_addr_t (ifconfig_local, 0, gc),
> print_in_addr_t (c->c2.push_ifconfig_remote_
> netmask,
> 0, gc));
> +
> + /* Warn if ifconfig_remote_netmask does not contain
> + * subnet mask in subnet topology */
>
If we go by the code this should be subnet and net30 topology.
By the way, style alert -- we want the ending */ on a line by itself, don't
we?
> + if ((c->options.topology == TOP_SUBNET || c->options.topology ==
> TOP_NET30)
> + && (c->c2.push_ifconfig_remote_netmask & 0xff000000) !=
> 0xff000000)
> + {
> + msg(M_WARN, "WARNING: When --topology is subnet or net30, the
> second argument "
> + "to --ifconfig-push MUST be a subnet mask. This client
> will not be able "
> + "to connect.");
+ }
> }
>
I don't know the code path well enough, so cant say anything technical...
Selva
------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
