On Wed, Nov 30, 2016 at 5:06 PM, Arne Schwabe <a...@rfc2549.org> wrote:
> >
> > The patch does what we agreed on in the trac ticket ("no user changes"
> > for the normal case, and "in the service pipe change, imply def1 if
> > no flags set"). This is very little extra code and easily checked,
> > while fixing this in other ways would need much more code - for a sort-of
> > historic approach to routing table handling (we really shouldn't be
> > *removing* other people's routes, and we don't do that for IPv6 either).
> >
> > Semi-ACK on the approach from Arne ("that's what we do on Android") :-)
>
> Slight correction. We actually set 0.0.0.0/0 on Android but Android
> *always* translates that into a 0.0.0.0/1 and a 128.0.0.0/1 rule.
>
> We could do the same and do the translation in the interactive service
> instead of OpenVPN itself.
Yeah that's an option but we'll have to make the HandleRouteMsg() code in
service
parse and understand the default route. Currently it just does what its
told to do (touch wood!).
When the service is taught to change things like that, it could come and
bite us one day..
The current approach is probably simpler.
Selva
------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
