ACK. Code looks reasonable, and it passes compilation.
I have not been able to actually TEST it due to scheduling conflicts
today, but I'm taking that risk, based on "it looks good, it affects
windows only, and unless the code is activated by *pushing* a DNS6
option, it will not affect existing setups at all".
In case someone wonders whether changing struct dns_cfg_message_t is
safe - it is, because we never had a "v4 DNS message" yet, that struct
was completely unused (and the new one is theoretically multi-protocol
capable, though not "mixed mode").
I did a small code fix, though - the netsh_dns_cmd() always reset
"err = 0" at the end:
+ err = ExecCommand (argv0, cmdline, timeout);
+
+out:
+ err = 0;
+ free (cmdline);
+ return err;
+}
.. which did not make sense, so I removed the "err = 0" line.
Your patch has been applied to the master branch.
commit c098016a22e90575e9c3e7c27d7b457ed9d1b5d3
Author: Selva Nair
Date: Wed Nov 23 22:35:27 2016 -0500
Set IPv6 DNS servers using interactive service
Signed-off-by: Selva Nair <selva.n...@gmail.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <1479958527-29491-1-git-send-email-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13222.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
